<div dir="ltr"><div>Looks OK to me.<br></div>Reviewed-by: Brian Paul <<a href="mailto:brianp@vmware.com">brianp@vmware.com</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 3, 2017 at 6:18 PM, Andres Gomez <span dir="ltr"><<a href="mailto:agomez@igalia.com" target="_blank">agomez@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Fixes: e76ecd048 ("framework: also print elapsed time with piglit-summary.py")<br>
<br>
Cc: Brian Paul <<a href="mailto:brianp@vmware.com">brianp@vmware.com</a>><br>
Cc: Dylan Baker <<a href="mailto:dylanx.c.baker@intel.com">dylanx.c.baker@intel.com</a>><br>
Signed-off-by: Andres Gomez <<a href="mailto:agomez@igalia.com">agomez@igalia.com</a>><br>
---<br>
unittests/framework/summary/<wbr>test_console.py | 14 +++++++++-----<br>
1 file changed, 9 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/unittests/framework/summary/<wbr>test_console.py b/unittests/framework/summary/<wbr>test_console.py<br>
index 0f7b06772..6e6ae8a7d 100644<br>
--- a/unittests/framework/summary/<wbr>test_console.py<br>
+++ b/unittests/framework/summary/<wbr>test_console.py<br>
@@ -53,6 +53,7 @@ _ENUMS = {<br>
13: 'fixes',<br>
14: 'regressions',<br>
15: 'total',<br>
+ 16: 'time',<br>
}<br>
<br>
class TestPrintSummary(object):<br>
@@ -67,11 +68,11 @@ class TestPrintSummary(object):<br>
"""<br>
names = [grouptools.join('foo', 'bar', 'oink', 'foobar', 'boink'),<br>
'foo', 'bar']<br>
- template = '{: >20.20} {: >6.6}'<br>
+ template = '{: >20.20} {: >12.12}'<br>
<br>
expected = console_._SUMMARY_TEMPLATE.<wbr>format(<br>
- names=' '.join(['this is a really rea', 'a name']),<br>
- divider=' '.join(['--------------------'<wbr>, '------']),<br>
+ names=' '.join(['this is a really rea', 'another name']),<br>
+ divider=' '.join(['--------------------'<wbr>, '------------']),<br>
pass_=template.format('1', '2'),<br>
fail=template.format('2', '0'),<br>
crash=template.format('0', '0'),<br>
@@ -84,7 +85,8 @@ class TestPrintSummary(object):<br>
changes=template.format('0', '2'),<br>
fixes=template.format('0', '1'),<br>
regressions=template.format('<wbr>0', '0'),<br>
- total=template.format('3', '3')).split('\n')<br>
+ total=template.format('3', '3'),<br>
+ time=template.format('00:01:<wbr>39', '02:14:05')).split('\n')<br>
<br>
res1 = results.TestrunResult()<br>
<a href="http://res1.name" rel="noreferrer" target="_blank">res1.name</a> = 'this is a really really really really long name'<br>
@@ -92,14 +94,16 @@ class TestPrintSummary(object):<br>
res1.tests[names[1]] = results.TestResult('fail')<br>
res1.tests[names[2]] = results.TestResult('notrun')<br>
res1.tests[names[2]].subtests[<wbr>'1'] = 'fail'<br>
+ res1.time_elapsed = results.TimeAttribute(<wbr>1509747121.4873962, 1509747220.544042)<br>
res1.calculate_group_totals()<br>
<br>
res2 = results.TestrunResult()<br>
- <a href="http://res2.name" rel="noreferrer" target="_blank">res2.name</a> = 'a name'<br>
+ <a href="http://res2.name" rel="noreferrer" target="_blank">res2.name</a> = 'another name'<br>
res2.tests[names[0]] = results.TestResult('pass')<br>
res2.tests[names[1]] = results.TestResult('pass')<br>
res2.tests[names[2]] = results.TestResult('notrun')<br>
res2.tests[names[2]].subtests[<wbr>'1'] = 'skip'<br>
+ res2.time_elapsed = results.TimeAttribute(<wbr>1464820707.4581327, 1464828753.201948)<br>
res2.calculate_group_totals()<br>
<br>
reses = common.Results([res1, res2])<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.14.2<br>
<br>
______________________________<wbr>_________________<br>
Piglit mailing list<br>
<a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/piglit" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/piglit</a><br>
</font></span></blockquote></div><br></div>