<div dir="ltr"><div><div>I think the bad enum is some copy and paste from an above test case. I feel it should be changed as well, right now the test is relying on the level / size being validated before the format.<br><br></div> - Anthony<br><br></div>P.S. Sorry for the spam on these changes, I had a problem with my filters and thought the changes weren't being sent, but well... they were.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 28, 2018 at 11:41 AM, Arthur Huillet <span dir="ltr"><<a href="mailto:arthur.huillet@free.fr" target="_blank">arthur.huillet@free.fr</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I'm confused why the test is passing a bad enum when its purpose seems to be to test a non-existent level.<br>
In any case, your change looks correct to me.<br>
<br>
Reviewed-by: Arthur Huillet <<a href="mailto:ahuillet@nvidia.com" target="_blank">ahuillet@nvidia.com</a>><br>
<br>
<br>
On 28.03.2018 17:15, Anthony Pesch wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
From: Anthony Pesch <<a href="mailto:apesch@nvidia.com" target="_blank">apesch@nvidia.com</a>><br>
<br>
Change expected error from INVALID_OPERATION to INVALID_VALUE when querying<br>
a level which hasn't been explicitly defined. This is a valid operation, the<br>
error set should be due to the requested width and height being greater than<br>
the default width and height of zero.<br>
---<br>
tests/spec/arb_get_texture_su<wbr>b_image/errors.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/tests/spec/arb_get_texture_s<wbr>ub_image/errors.c<br>
b/tests/spec/arb_get_texture_s<wbr>ub_image/errors.c<br>
index 34fec4a95..57875fa6a 100644<br>
--- a/tests/spec/arb_get_texture_s<wbr>ub_image/errors.c<br>
+++ b/tests/spec/arb_get_texture_s<wbr>ub_image/errors.c<br>
@@ -200,7 +200,7 @@ test_invalid_values(void)<br>
8, 8, 1, /* size */<br>
GL_RGBA, GL_FLOAT, /* bad enum */<br>
sizeof(buffer), buffer);<br>
- if (!piglit_check_gl_error(GL_INV<wbr>ALID_OPERATION))<br>
+ if (!piglit_check_gl_error(GL_INV<wbr>ALID_VALUE))<br>
pass = false;<br>
<br>
/* Test getting invalid offset */<span class="HOEnZb"><font color="#888888"><br>
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
<br>
-- <br>
A. Huillet<br>
</font></span></blockquote></div><br></div>