<div dir="ltr"><div>Hello.</div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Seems reasonable,<br></span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Reviewed-by: Dylan Baker <</span><a href="mailto:dylan@pnwbakers.com" style="color:rgb(17,85,204);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)">dylan@pnwbakers.com</a><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">></span></blockquote><div class="gmail-yj6qo" style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"></div><br></div>Could we push it?</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 8, 2018 at 6:51 PM, Dylan Baker <span dir="ltr"><<a href="mailto:dylan@pnwbakers.com" target="_blank">dylan@pnwbakers.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Quoting Sergii Romantsov (2018-06-08 02:19:01)<br>
<div><div class="h5">> If system has installed both GL libraries such as<br>
> Legacy and GLVND, cmake will dump warning:<br>
> <br>
> "OpenGL_GL_PREFERENCE has not been set to "GLVND" or "LEGACY",<br>
> so for compatibility with CMake 3.10 and below the legacy GL<br>
> library will be used."<br>
> <br>
> Added usage of Policy CMP0072 as OLD (that selects LEGACY-library<br>
> libGL.so by default).<br>
> <br>
> Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=106857" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/<wbr>show_bug.cgi?id=106857</a><br>
> Signed-off-by: Sergii Romantsov <<a href="mailto:sergii.romantsov@globallogic.com">sergii.romantsov@globallogic.<wbr>com</a>><br>
> ---<br>
> CMakeLists.txt | 4 ++++<br>
> 1 file changed, 4 insertions(+)<br>
> <br>
> diff --git a/CMakeLists.txt b/CMakeLists.txt<br>
> index e56aafb..02bdc56 100644<br>
> --- a/CMakeLists.txt<br>
> +++ b/CMakeLists.txt<br>
> @@ -15,6 +15,10 @@ if (POLICY CMP0042)<br>
> cmake_policy (SET CMP0042 NEW)<br>
> endif()<br>
> <br>
> +if (POLICY CMP0072)<br>
> + cmake_policy (SET CMP0072 OLD)<br>
> +endif()<br>
> +<br>
> project (piglit)<br>
> <br>
> # Require MinGW<br>
> -- <br>
> 2.7.4<br>
> <br>
</div></div>> ______________________________<wbr>_________________<br>
> Piglit mailing list<br>
> <a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/piglit" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/piglit</a><br>
<br>
Seems reasonable,<br>
Reviewed-by: Dylan Baker <<a href="mailto:dylan@pnwbakers.com">dylan@pnwbakers.com</a>><br>
</blockquote></div><br></div>