<div dir="ltr">Hi,<br><div><div class="gmail_extra"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><p>On 21/08/18 21:38, <a class="gmail-m_643991289169501866moz-txt-link-abbreviated" href="mailto:asimiklit.work@gmail.com" target="_blank">asimiklit.work@gmail.com</a> wrote:<br>
</p><blockquote type="cite">
<pre>From: Andrii Simiklit <a class="gmail-m_643991289169501866moz-txt-link-rfc2396E" href="mailto:andrii.simiklit@globallogic.com" target="_blank"><andrii.simiklit@globallogic.<wbr>com></a>
According to spec:
"For an active variable declared as an array of an aggregate data type
(structures or arrays), a separate entry will be generated for each
active array element, unless noted immediately below ..."
Mesa should return valid index for 'vs_input2[1][0]' cases.</pre>
</blockquote>
I believe the key word above is "active" yes they are separate but
if I'm remembering this problem correctly they are not all active.
<pre class="gmail-m_643991289169501866bz_comment_text" id="gmail-m_643991289169501866comment_text_2">I believe this is a Mesa bug not a piglit bug, it was just tricky to fix and always a low priority.
See: <a class="gmail-m_643991289169501866bz_bug_link gmail-m_643991289169501866bz_status_ASSIGNED" title="ASSIGNED - [GEN6+] arb_program_interface_query.arb_program_interface_query-getprogramresourceindex regression" href="https://bugs.freedesktop.org/show_bug.cgi?id=92822#c7" target="_blank">https://bugs.freedesktop.org/<wbr>show_bug.cgi?id=92822#c7</a></pre></blockquote>
</div>Thanks for your fast reply.<br>Yes you are right I missed it in my investigation.</div><div><br></div><div>Regards,</div><div>Andrii.<br></div><div><br><div class="gmail_extra"><div class="gmail_quote">On Tue, Aug 21, 2018 at 3:46 PM, Timothy Arceri <span dir="ltr"><<a href="mailto:tarceri@itsqueeze.com" target="_blank">tarceri@itsqueeze.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<p>On 21/08/18 21:38, <a class="gmail-m_643991289169501866moz-txt-link-abbreviated" href="mailto:asimiklit.work@gmail.com" target="_blank">asimiklit.work@gmail.com</a> wrote:<br>
</p>
<blockquote type="cite">
<pre>From: Andrii Simiklit <a class="gmail-m_643991289169501866moz-txt-link-rfc2396E" href="mailto:andrii.simiklit@globallogic.com" target="_blank"><andrii.simiklit@globallogic.<wbr>com></a>
According to spec:
"For an active variable declared as an array of an aggregate data type
(structures or arrays), a separate entry will be generated for each
active array element, unless noted immediately below ..."
Mesa should return valid index for 'vs_input2[1][0]' cases.</pre>
</blockquote>
I believe the key word above is "active" yes they are separate but
if I'm remembering this problem correctly they are not all active.
<pre class="gmail-m_643991289169501866bz_comment_text" id="gmail-m_643991289169501866comment_text_2">I believe this is a Mesa bug not a piglit bug, it was just tricky to fix and always a low priority.
See: <a class="gmail-m_643991289169501866bz_bug_link gmail-m_643991289169501866bz_status_ASSIGNED" title="ASSIGNED - [GEN6+] arb_program_interface_query.arb_program_interface_query-getprogramresourceindex regression" href="https://bugs.freedesktop.org/show_bug.cgi?id=92822#c7" target="_blank">https://bugs.freedesktop.org/<wbr>show_bug.cgi?id=92822#c7</a></pre>
<blockquote type="cite">
<pre>Bugzilla: <a class="gmail-m_643991289169501866moz-txt-link-freetext" href="https://bugs.freedesktop.org/show_bug.cgi?id=107639" target="_blank">https://bugs.freedesktop.org/<wbr>show_bug.cgi?id=107639</a>
Signed-off-by: Andrii Simiklit <a class="gmail-m_643991289169501866moz-txt-link-rfc2396E" href="mailto:andrii.simiklit@globallogic.com" target="_blank"><andrii.simiklit@globallogic.<wbr>com></a>
---
tests/spec/arb_program_<wbr>interface_query/<wbr>getprogramresourceindex.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/spec/arb_program_<wbr>interface_query/<wbr>getprogramresourceindex.c b/tests/spec/arb_program_<wbr>interface_query/<wbr>getprogramresourceindex.c
index 16b38e2..92d9a90 100755
--- a/tests/spec/arb_program_<wbr>interface_query/<wbr>getprogramresourceindex.c
+++ b/tests/spec/arb_program_<wbr>interface_query/<wbr>getprogramresourceindex.c
@@ -167,8 +167,9 @@ static const struct subtest_index_t index_subtests[] = {
{ vs_aofa, GL_PROGRAM_INPUT, "vs_input2", false, -1, GL_NO_ERROR },
{ vs_aofa, GL_PROGRAM_INPUT, "vs_input2[0]", true, -1, GL_NO_ERROR },
{ vs_aofa, GL_PROGRAM_INPUT, "vs_input2[0][0]", true, -1, GL_NO_ERROR },
- { vs_aofa, GL_PROGRAM_INPUT, "vs_input2[1][0]", false, -1, GL_NO_ERROR },
+ { vs_aofa, GL_PROGRAM_INPUT, "vs_input2[1][0]", true, -1, GL_NO_ERROR },
{ vs_aofa, GL_PROGRAM_INPUT, "vs_input2[0][1]", false, -1, GL_NO_ERROR },
+ { vs_aofa, GL_PROGRAM_INPUT, "vs_input2[1][1]", false, -1, GL_NO_ERROR },
{ vs_sub, GL_VERTEX_SUBROUTINE, "vss", true, -1, GL_NO_ERROR },
{ vs_sub, GL_VERTEX_SUBROUTINE, "vss2", true, -1, GL_NO_ERROR },
{ vs_subidx, GL_VERTEX_SUBROUTINE, "vss_idx", true, 5, GL_NO_ERROR },
</pre>
</blockquote>
<br>
</div>
</blockquote></div><br></div></div></div>