<div dir='auto'><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Nov 5, 2018 19:20, Ilia Mirkin <imirkin@alum.mit.edu> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Unless there's something that makes this a pain for ES2, I'd rather
<br>
these tests were runnable with gl_es_version = 20. You can test with
<br>
MESA_GLES_VERSION_OVERRIDE=20.</p></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Yeah, I already started on this. There's a few of them that won't work on es2, like the blitframebuffer test etc. I'll send an updated version soon. </div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">
<br>
On Mon, Nov 5, 2018 at 12:23 PM Erik Faye-Lund
<br>
<erik.faye-lund@collabora.com> wrote:
<br>
>
<br>
> These two tests are trivial to port to GLES 3.
<br>
>
<br>
> Signed-off-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
<br>
> ---
<br>
>  tests/spec/nv_conditional_render/CMakeLists.gles3.txt | 6 ++++++
<br>
>  tests/spec/nv_conditional_render/begin-while-active.c | 4 ++++
<br>
>  tests/spec/nv_conditional_render/begin-zero.c         | 5 +++++
<br>
>  3 files changed, 15 insertions(+)
<br>
>  create mode 100644 tests/spec/nv_conditional_render/CMakeLists.gles3.txt
<br>
>
<br>
> diff --git a/tests/spec/nv_conditional_render/CMakeLists.gles3.txt b/tests/spec/nv_conditional_render/CMakeLists.gles3.txt
<br>
> new file mode 100644
<br>
> index 000000000..5cd5970ff
<br>
> --- /dev/null
<br>
> +++ b/tests/spec/nv_conditional_render/CMakeLists.gles3.txt
<br>
> @@ -0,0 +1,6 @@
<br>
> +link_libraries(piglitutil_${piglit_target_api})
<br>
> +
<br>
> +piglit_add_executable (nv_conditional_render-begin-while-active_gles3 begin-while-active.c)
<br>
> +piglit_add_executable (nv_conditional_render-begin-zero_gles3 begin-zero.c)
<br>
> +
<br>
> +# vim: ft=cmake:
<br>
> diff --git a/tests/spec/nv_conditional_render/begin-while-active.c b/tests/spec/nv_conditional_render/begin-while-active.c
<br>
> index 821544113..9b8488763 100644
<br>
> --- a/tests/spec/nv_conditional_render/begin-while-active.c
<br>
> +++ b/tests/spec/nv_conditional_render/begin-while-active.c
<br>
> @@ -42,7 +42,11 @@
<br>
>
<br>
>  PIGLIT_GL_TEST_CONFIG_BEGIN
<br>
>
<br>
> +#ifdef PIGLIT_USE_OPENGL
<br>
>         config.supports_gl_compat_version = 10;
<br>
> +#else // PIGLIT_USE_OPENGL_ES3
<br>
> +       config.supports_gl_es_version = 30;
<br>
> +#endif
<br>
>
<br>
>         config.window_visual = PIGLIT_GL_VISUAL_RGBA;
<br>
>         config.khr_no_error_support = PIGLIT_HAS_ERRORS;
<br>
> diff --git a/tests/spec/nv_conditional_render/begin-zero.c b/tests/spec/nv_conditional_render/begin-zero.c
<br>
> index 85304643c..0777d5c70 100644
<br>
> --- a/tests/spec/nv_conditional_render/begin-zero.c
<br>
> +++ b/tests/spec/nv_conditional_render/begin-zero.c
<br>
> @@ -40,7 +40,12 @@
<br>
>
<br>
>  PIGLIT_GL_TEST_CONFIG_BEGIN
<br>
>
<br>
> +#ifdef PIGLIT_USE_OPENGL
<br>
>         config.supports_gl_compat_version = 10;
<br>
> +#else // PIGLIT_USE_OPENGL_ES3
<br>
> +       config.supports_gl_es_version = 30;
<br>
> +#endif
<br>
> +
<br>
>         config.window_visual = PIGLIT_GL_VISUAL_RGBA;
<br>
>         config.khr_no_error_support = PIGLIT_HAS_ERRORS;
<br>
>
<br>
> --
<br>
> 2.19.1
<br>
>
<br>
> _______________________________________________
<br>
> Piglit mailing list
<br>
> Piglit@lists.freedesktop.org
<br>
> https://lists.freedesktop.org/mailman/listinfo/piglit
<br>
</p>
</blockquote></div><br></div></div></div>