<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:lemody@gmail.com" title="Tapani Pälli <lemody@gmail.com>"> <span class="fn">Tapani Pälli</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - The spec@arb_program_interface_query@arb_program_interface_query-getprogramresourceiv fails"
href="https://bugs.freedesktop.org/show_bug.cgi?id=108612">bug 108612</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - The spec@arb_program_interface_query@arb_program_interface_query-getprogramresourceiv fails"
href="https://bugs.freedesktop.org/show_bug.cgi?id=108612#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - The spec@arb_program_interface_query@arb_program_interface_query-getprogramresourceiv fails"
href="https://bugs.freedesktop.org/show_bug.cgi?id=108612">bug 108612</a>
from <span class="vcard"><a class="email" href="mailto:lemody@gmail.com" title="Tapani Pälli <lemody@gmail.com>"> <span class="fn">Tapani Pälli</span></a>
</span></b>
<pre>Fixed!
--- 8< ---
commit a96854e3406be69abca77e1e9ce63720e7a3c985
Author: Andrii Simiklit <<a href="mailto:andrii.simiklit@globallogic.com">andrii.simiklit@globallogic.com</a>>
Date: Wed Oct 31 17:05:56 2018 +0200
program_interface_query: don't expect a valid location for TCS output
I guess we should not expect a valid location for:
"patch out vec4 tcs_patch;"
because this output variable is declareted
without "layout (location=X)" and according to spec:
"Not all active variables are assigned valid locations; the
following variables will have an effective location of -1:
* uniforms declared as atomic counters;
* members of a uniform block;
* built-in inputs, outputs, and uniforms (starting with "gl_"); and
* inputs or outputs not declared with a "location" layout qualifier,
except for vertex shader inputs and fragment shader outputs."
Also I fixed some conflicting comments.
Bugzilla: <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - The spec@arb_program_interface_query@arb_program_interface_query-getprogramresourceiv fails"
href="show_bug.cgi?id=108612">https://bugs.freedesktop.org/show_bug.cgi?id=108612</a>
Signed-off-by: Andrii Simiklit <<a href="mailto:andrii.simiklit@globallogic.com">andrii.simiklit@globallogic.com</a>>
Reviewed-by: Tapani Pälli <<a href="mailto:tapani.palli@intel.com">tapani.palli@intel.com</a>></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>