<div dir="ltr">Hello, Tapani, Eric.<div> <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">No worries, I'm OK with using this patch too.</blockquote><div> </div><div>Can it be treated as r-b? </div></div></div> <div class="gmail_quote"><div dir="ltr">On Wed, Jan 16, 2019 at 11:06 AM Tapani Pälli <<a href="mailto:tapani.palli@intel.com">tapani.palli@intel.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> On 1/15/19 5:02 PM, Sergii Romantsov wrote: > Hello, > > Yep, it seems valgrind outputs bunch of invalid reads and writes with > this test. > > Seems any test with valgrind generates invalid reads and writes... > Probably it depends on macros-usage: probably they are not properly > handled by valgrind Yeah this may be but this time it points directly to the test code as well. > It just seems a bit strange to first calculate a 'maximum' > miplevel but then use even bigger value in the test :) > > I would say that max level is calculated properly, but in test also used > 0-level, which seems included as +1 to max_miplevel > > Alternatively I guess one could change those loops to not exceed max > level, use < operator instead of <= (?) > > If no more any objections - will update to '<' No worries, I'm OK with using this patch too. > On Tue, Jan 15, 2019 at 3:07 PM Tapani Pälli <<a href="mailto:tapani.palli@intel.com" target="_blank">tapani.palli@intel.com</a> > <mailto:<a href="mailto:tapani.palli@intel.com" target="_blank">tapani.palli@intel.com</a>>> wrote: > > > On 1/14/19 12:51 PM, Sergii Romantsov wrote: > > Usage test 'depthstencil-render-miplevels 200 s=z24_s8' causes > > core dump on exit. > > Fixed: array of pointers is allocated to size max_miplevel, but > > used as max_miplevel + 1. > > Yep, it seems valgrind outputs bunch of invalid reads and writes with > this test. > > Alternatively I guess one could change those loops to not exceed max > level, use < operator instead of <= (?) I'm not sure if other > calculations would match so some careful investigation would be > required > there. It just seems a bit strange to first calculate a 'maximum' > miplevel but then use even bigger value in the test :) > > > > CC: Eric Anholt <<a href="mailto:eric@anholt.net" target="_blank">eric@anholt.net</a> <mailto:<a href="mailto:eric@anholt.net" target="_blank">eric@anholt.net</a>>> > > Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=108819" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=108819</a> > > Fixes: 7a0e61d7792f (depthstencil-render-miplevels: Present the > results in non-auto mode.) > > Signed-off-by: Sergii Romantsov <<a href="mailto:sergii.romantsov@globallogic.com" target="_blank">sergii.romantsov@globallogic.com</a> > <mailto:<a href="mailto:sergii.romantsov@globallogic.com" target="_blank">sergii.romantsov@globallogic.com</a>>> > > --- > > tests/texturing/depthstencil-render-miplevels.cpp | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tests/texturing/depthstencil-render-miplevels.cpp > b/tests/texturing/depthstencil-render-miplevels.cpp > > index 87af92f..9d4b42d 100644 > > --- a/tests/texturing/depthstencil-render-miplevels.cpp > > +++ b/tests/texturing/depthstencil-render-miplevels.cpp > > @@ -360,8 +360,8 @@ piglit_init(int argc, char **argv) > > piglit_require_extension("GL_ARB_depth_texture"); > > piglit_require_extension("GL_ARB_texture_non_power_of_two"); > > > > - depth_miplevel_data = (float **)calloc(max_miplevel, > sizeof(float *)); > > - stencil_miplevel_data = (uint8_t **)calloc(max_miplevel, > > + depth_miplevel_data = (float **)calloc(max_miplevel + 1, > sizeof(float *)); > > + stencil_miplevel_data = (uint8_t **)calloc(max_miplevel + 1, > > sizeof(uint8_t *)); > > > > /* argv[2]: buffer combination */ > > > </blockquote></div>