[Pixman] is whitespace clean-up good for the upstream?

Soeren Sandmann sandmann at daimi.au.dk
Sat Aug 28 09:09:28 PDT 2010

Dmitri Vorobiev <dmitri.vorobiev at movial.com> writes:

> While working on a task, which is only loosely related to Pixman
> upstream, I noticed that Pixman sources contain quite many lines
> consisting of whitespace only. Since such lines have an adverse effect
> on what I am doing now, I am cleaning away such whitespaces. I could
> submit a patch doing such clean-up, however, I would like to know
> first if it is interesting for Pixman maintainers and would be
> applied.

I'm curious why this whitespace is a problem. The CODING_STYLE
document used to says something about avoiding trailing whitespace,
but I removed it recently because it just doesn't bother me.

> So, my question is: it there any interest in applying a code clean-up
> patch that does not change any functionality (and even does not change
> any compiled code)?

If there is some good reason to do this, it could be considered, but
this kind of formatting change tends to introduce gratuitous conflicts
in people's branches.


More information about the Pixman mailing list