[Pixman] [PATCH] Store a2b2g2r2 pixel through the WRITE macro

Siarhei Siamashka siarhei.siamashka at gmail.com
Mon Aug 30 04:24:36 PDT 2010


On Monday 30 August 2010 07:17:20 Søren Sandmann wrote:
> From: Søren Sandmann Pedersen <ssp at redhat.com>
> 
> Otherwise, accessor functions won't work.
> ---
>  pixman/pixman-access.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/pixman/pixman-access.c b/pixman/pixman-access.c
> index 56de711..f1ce0ba 100644
> --- a/pixman/pixman-access.c
> +++ b/pixman/pixman-access.c
> @@ -2425,11 +2425,11 @@ store_scanline_a2b2g2r2 (bits_image_t *  image,
>      {
>  	SPLIT_A (values[i]);
> 
> -	*(pixel++) =
> -	    ((a     ) & 0xc0) |
> -	    ((b >> 2) & 0x30) |
> -	    ((g >> 4) & 0x0c) |
> -	    ((r >> 6)       );
> +	WRITE (image, pixel++,
> +	       ((a     ) & 0xc0) |
> +	       ((b >> 2) & 0x30) |
> +	       ((g >> 4) & 0x0c) |
> +	       ((r >> 6)       ));
>      }
>  }

Would it generally be a good idea to extend pixman tests to also cover the use
of accessors?

-- 
Best regards,
Siarhei Siamashka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/pixman/attachments/20100830/82d762a3/attachment.pgp>


More information about the Pixman mailing list