[Pixman] [PATCH] Add support for 18bpp X14R6G6B6 format.

[Soeren Sandmann]

Marek Vasut <marek.vasut at gmail.com> writes:

> > that the format needs to be added to
> > pixman_format_supported_source().

I don't think you fixed this.

> > > +fetch_scanline_x14r6g6b6 (pixman_image_t *image,
> > > +                       int             x,
> > > +                       int             y,
> > > +                       int             width,
> > > +                       uint32_t *      buffer,
> > > +                       const uint32_t *mask,
> > > +                       uint32_t        mask_bits)
> > 
> > Please make sure all the arguments are aligned, instead of just
> > leaving the indentation in place from where cutted-and-pasted. This
> > applies to the other functions as well.
> 
> Hey,
> 
> this would better apply to the whole file. Maybe some coding-style cleanup wont 
> hurt there. The reason I didn't use tabs for indent is exactly this -- to 
> maintain consistency with the other function. I'll send an updated
> patch.

I didn't mean use tabs, I meant make sure the arguments are formatted
like this:

       fetch_scanline_x14r6g6b6 (pixman_image_t *image,
                                 int             x,
                                 int             y,
                                 int             width,
                                 uint32_t *      buffer,
                                 const uint32_t *mask)

In your original patch they were indented like this:

       fetch_scanline_x14r6g6b6 (pixman_image_t *image,
                              int             x,
                              int             y,
                              int             width,
                              uint32_t *      buffer,
                              const uint32_t *mask,
                              uint32_t        mask_bits)

It's fine to use spaces for indentation, and in fact necessary since
we use four-space indents and the TAB character is considered
equivalent to eight spaces. Please see the CODING_STYLE document.

The rest of the file is formatted like this already.


Soren