[Pixman] [PATCH] ARM: NEON: don't hit general path for r5g6b5 OVER r5g6b5 operation

Soeren Sandmann sandmann at daimi.au.dk
Wed May 26 01:51:40 PDT 2010

Hi Siarhei,

> From: Siarhei Siamashka <siarhei.siamashka at nokia.com>
> OVER can't be reduced to SRC because the source image is not
> considered opaque when repeat is set to PIXMAN_REPEAT_NONE.
> An additional fast path table entry solves the problem.

It solves the problem for r5g6b5 on NEON, but not in any other
cases. We have the same issue on every backend with every format
without alpha. Adding special cases for all of them would quickly get
unwieldy (and actually be impossible for the general implementation).

Would it be possible instead to add a new flag "OPAQUE_SAMPLES" that
would be set whenever the image format is opaque, and then use it
along with SAMPLES_COVER_CLIP to add the OPAQUE flag before strength
reducing the operator?

That would help all the backends, including the general one, and all
the opaque image formats.


More information about the Pixman mailing list