[Pixman] [PATCH] Plug leak in the alphamap test.

Soeren Sandmann sandmann at daimi.au.dk
Tue Oct 26 12:16:54 PDT 2010

Jon TURNEY <jon.turney at dronecode.org.uk> writes:

> Even with this fix, the cygwin tinderbox is still failing (silently)
> [1]. The alphamap process grows to 2G in size and then mmap() starts
> failing.
> It looks like this is because we are still leaking the alphamap
> pixmaps. Attached is a patch to fix this, although I am not very
> familiar with the pixman API, so this might not be the best way to do
> this :-)

It's close enough. I have pushed it to master.

> It would be better if this failure wasn't silent, I only noticed it
> by accident.

On the other hand, isn't it a little iffy to fail the test suite just
because malloc() or mmap() failed? Though, I guess many of the tests
would actually fail in that case anyway.


More information about the Pixman mailing list