[Pixman] [PATCH 1/3] Nearest scaling fast path macro moved to header file and split into parts

Soeren Sandmann sandmann at daimi.au.dk
Fri Sep 10 03:09:55 PDT 2010


Siarhei Siamashka <siarhei.siamashka at gmail.com> writes:

> From: Siarhei Siamashka <siarhei.siamashka at nokia.com>
> 
> Scanline processing is splitted into a separate function. This provides
> an easy way of overriding it with a platform specific implementation,
> which may use SIMD optimizations. Only basic C data types are used as
> the arguments for this function, so it may be implemented entirely in
> assembly or be generated by some JIT engine.
> 
> All the nearest scaling related macros are moved to 'pixman-fast-path.h'
> header file because they are supposed to be used by different platform
> specific implementations.

One comment on this: Can the moving and the modifying of the macros be
split into separate commits? That way, git will preserve history
better.

I haven't otherwise read the code yet, but I like the general
approach.


Soren


More information about the Pixman mailing list