[Pixman] [PATCH] Add a lowlevel blitter benchmark

[Dmitri Vorobiev]

On Wed, Sep 15, 2010 at 5:06 PM, Soeren Sandmann <sandmann at daimi.au.dk> wrote:
> Dmitri Vorobiev <dmitri.vorobiev at movial.com> writes:
>
>> diff --git a/test/Makefile.am b/test/Makefile.am
>> index 3d98e17..8f3fdaf 100644
>> --- a/test/Makefile.am
>> +++ b/test/Makefile.am
>> @@ -18,7 +18,8 @@ TESTPROGRAMS =                      \
>>       scaling-crash-test      \
>>       blitters-test           \
>>       scaling-test            \
>> -     composite
>> +     composite               \
>> +     lowlevel-blt-bench
>
> As Siarhei mentioned, this shouldn't go in TESTPROGRAMS. Eventually,
> I'd like to have a separate performance test suite, perhaps even in
> its own directory next to test, but for now, let's just add it in the
> test directory.

Understood.

>
>> +++ b/test/lowlevel-blt-bench.c
>> @@ -0,0 +1,713 @@
>> +/*
>> + * Copyright © 2010 Movial Creative Technologies Oy
>> + *
>> + * Permission to use, copy, modify, distribute, and sell this software and its
>> + * documentation for any purpose is hereby granted without fee, provided that
>> + * the above copyright notice appear in all copies and that both that
>> + * copyright notice and this permission notice appear in supporting
>> + * documentation, and that the name of ARM Ltd not be used in
>> + * advertising or publicity pertaining to distribution of the software without
>> + * specific, written prior permission.  ARM Ltd makes no
>> + * representations about the suitability of this software for any purpose.  It
>> + * is provided "as is" without express or implied warranty.
>> + *
>> + * THE COPYRIGHT HOLDERS DISCLAIM ALL WARRANTIES WITH REGARD TO THIS
>> + * SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND
>> + * FITNESS, IN NO EVENT SHALL THE COPYRIGHT HOLDERS BE LIABLE FOR ANY
>> + * SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
>> + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN
>> + * AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING
>> + * OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS
>> + * SOFTWARE.
>> + *
>> + * Author:  Jonathan Morton (jonathan.morton at movial.com)
>> + *
>> + * Based on the code by Siarhei Siamashka <siarhei.siamashka at gmail.com>
>> + *
>> + */
>
> This says copyright Movial, but mentions ARM Ltd in the text.
>
> Unless you have a reason to not use it, the preferred license is the
> one in COPYING. Its main advantage is that it avoids this kind of
> cut-and-paste issue.
>
> Also, is this code mainly written by Siarhei? If so, presumably either
> Nokia or Siarhei are also copyright holders.

Thanks, will take that into account.

>
>> +tests_tbl[] =
>> +{
>>      ....
>> +    { "src_n_2222",            PIXMAN_a8r8g8b8,    1, PIXMAN_OP_SRC,     PIXMAN_null,     0, PIXMAN_a1r5g5b5 },
>
> This one looks like it should have a2r2g2b2 in the destination

Thanks, will look at that.

>
>> +    { "src_n_4444",            PIXMAN_a8r8g8b8,    1, PIXMAN_OP_SRC,     PIXMAN_null,     0, PIXMAN_a1r5g5b5 },
>
> This one looks wrong too.

Ditto.

>
>> +/* Return time since the Epoch in seconds */
>> +double
>> +gettime (void);
>
> Like the malloc() changes, this could usefully be done in its own patch.

Yes, I will submit a gettime()-only patch soon.

Thanks,
Dmitri