[Pixman] [PATCH 1/1] Add a lowlevel blitter benchmark

Soeren Sandmann sandmann at daimi.au.dk
Fri Sep 17 04:31:08 PDT 2010


> +#include <stdint.h>
> +#include <stdio.h>
> +#include <string.h>
> +#include <stdlib.h>
> +#include <unistd.h>
> +#include <stdlib.h>
> +#include <malloc.h>

I don't think either unistd.h or malloc.h needs to be included here.

> +void __attribute__((noinline))

__attribute__((noinline)) is GCC specific, so it needs to be defined
in pixman-compiler.h similarly to force_inline. I think the Visual C
version is called __declspec(noinline).

Also, in the gettime patch, utils.c needs to include <sys/time.h> to
get the prototype for gettimeofday(). It should be checked for in
configure.ac with AC_CHECK_HEADER().

Other than that, these patches look good to me.


More information about the Pixman mailing list