[Pixman] [PATCH 2/3] ARM: NEON scanline functions for bilinear scaling with A8 mask

[Siarhei Siamashka]

On Wed, Apr 13, 2011 at 10:12 PM, Soeren Sandmann <sandmann at cs.au.dk> wrote:
> Taekyun Kim <podain77 at gmail.com> writes:
>
>> +/*
>> + * Bilinear macros from pixman-arm-neon-asm.S
>> + */
>
> Am I missing something,

We tried to discuss it here:
http://lists.freedesktop.org/archives/pixman/2011-April/001193.html

> or are these macros being duplicated between
> pixman-arm-neon-asm.S and this new file? If so, maybe it would be better
> to put them in a header file and share them.

The whole problem with sharing these macros is that they already did
change a bit, and they are going to change even more in order to
improve performance. Taekyun Kim took the initial implementation of
NEON bilinear code and extended it to support more compositing
operations such as OVER and ADD, thus branching the older code. And
because we don't have a stable foundation yet, it seems to be not very
practical updating his code right now to use newer revisions of these
common macros because these macros are still going to be updated
again. I suggested taking his code as-is for pixman-0.22.0 in order to
give the rest of the world at least some more or less complete set of
ARM NEON bilinear fast paths sooner.

-- 
Best regards,
Siarhei Siamashka