[Pixman] [PATCH 2/4] New test of pixman_region_contains_{rectangle, point}

[Soeren Sandmann]

Andrea Canciani <ranma42 at gmail.com> writes:

> On Thu, Aug 4, 2011 at 6:32 AM, Soeren Sandmann <sandmann at cs.au.dk> wrote:
>> Søren Sandmann <sandmann at cs.au.dk> writes:
>>
>>> From: Søren Sandmann Pedersen <ssp at redhat.com>
>>>
>>> This test generates random regions and checks whether random boxes and
>>> points are contained within them. The results are combined and a CRC32
>>> value is computed and compared to a known-correct one.
>>
>> Apparently, I forgot to add the region-contains-test.c file, but it was
>> buggy anyway and had endian issues. Below is a new version of that patch.
>
> In the endianness test, why is the variable marked as volatile?
> (I'm not saying it's wrong, I'm just saying I don't understand it)
> Apart from this and some trailing whitespace,
>
> Reviewed-by: Andrea Canciani <ranma42 at gmail.com>

The endian test was written by Siarhei originally, but my guess is that
without it, compilers might decide to optimize the whole thing away,
which could be an issue on architectures that support both big and
little endian modes.


Soren