[Pixman] [PATCH/RFC] Move Trapezoids and Triangles code to pixman
Adam Jackson
ajax at nwnk.net
Mon Feb 14 14:58:28 PST 2011
On Feb 11, 2011, at 9:54 AM, Søren Sandmann Pedersen wrote:
> What follows is six patches for pixman, and three patches for the X
> server. Together they move the code for the Trapezoids and Triangles
> requests into pixman.
>
> Moving them into pixman has some advantages:
>
> - It is a performance improvement in itself since it avoids a call to
> image_from_pict() per trapezoid.
Which is to say, a malloc per trapezoid.
> - There are various potential optimizations that could be done by
> rasterizing and compositing in one pass.
>
> - There is a regression test suite for them.
Actual tests! My hero.
My only complaint was going to be about not dropping ps->Rasterize*, but of
course exa and uxa are still using them, so we can't do that yet. Still,
definite improvement.
Reviewed-by: Adam Jackson <ajax at redhat.com>
- ajax
More information about the Pixman
mailing list