[Pixman] [PATCH] Avoid marking images dirty when properties are reset

Soeren Sandmann sandmann at cs.au.dk
Wed Feb 16 03:59:32 PST 2011


Andrea Canciani <ranma42 at gmail.com> writes:

> > @@ -502,7 +502,7 @@ pixman_image_set_transform (pixman_image_t * ═ ═ ═ ═ ═image,
> > ═ ═ if (common->transform == transform)
> > ═ ═ ═ ═return TRUE;
> >
> > - ═ ═if (memcmp (&id, transform, sizeof (pixman_transform_t)) == 0)
> > + ═ ═if (!transform || memcmp (&id, transform, sizeof (pixman_transform_t)) == 0)
> > ═ ═ {
> > ═ ═ ═ ═free (common->transform);
> > ═ ═ ═ ═common->transform = NULL;
> 
> This change looks like a bugfix unrelated to the commit message.
> Overall, the patch looks correct.

Yeah, or I guess you could call it a new feature; either way, I'll
split it into a separate commit before pushing.

Thanks,
Soren


More information about the Pixman mailing list