[Pixman] Win32 fixes and improvements

Andrea Canciani ranma42 at gmail.com
Sat Feb 26 04:45:57 PST 2011


On Thu, Feb 24, 2011 at 6:43 PM, Soeren Sandmann <sandmann at cs.au.dk> wrote:
> Andrea Canciani <ranma42 at gmail.com> writes:
>
>> I improved the patchset a little (I fixed the library makefile for real
>> and silenced the test warnings) and pushed it as a git branch here:
>> http://cgit.freedesktop.org/~ranma42/pixman/log/?h=wip/win32
>
> I don't really know anything about Windows build systems, but regarding
> the snprintf() thing: Can't we just use sprintf()? We know the maximum
> sizes of everything involved, and in the end it's just a test program so
> if there's a buffer overflow, it's not the end of the world.

I reverted and replaced snprintf with sprintf as you suggested.
The new branch is available here:
http://cgit.freedesktop.org/~ranma42/pixman/log/?h=wip/win32-sprintf

This branch passes the whole test suite both on on MacOS and Win32,
so if nobody complains, I'll push it in a couple of days.

Andrea


More information about the Pixman mailing list