[Pixman] [PATCH 3/7] C variant of bilinear scaled 'src_8888_8888' fast path

Siarhei Siamashka siarhei.siamashka at gmail.com
Sat Feb 26 10:29:53 PST 2011

On Saturday 26 February 2011 14:33:02 Soeren Sandmann wrote:
> The pixman-fast-path.h file also contains a duplicated version of
> "repeat" where the only difference is that the order of the arguments is
> reversed and one uses MOD(), the other while() to do repeating. This
> duplication was not introduced by you, but it would be useful to share
> that code as well.

Yes, there is another one in 'pixman-bits-image' and they indeed could be
combined. But this really is not directly related to this particular patch

Also there is a duplication of functionality between SIMPLE_NEAREST_FAST_PATH
provides almost all functionality of NEAREST_FAST_PATH except for
REFLECT repeat. I always considered to do something about REFLECT repeat
in SIMPLE_NEAREST_FAST_PATH, but the fact that it does not seem to be used
anywhere does provide much motivation. But if REFLECT repeat is not so
important, maybe NEAREST_FAST_PATH can be just dropped in order to save
code size?

> Maybe the file pixman-fast-path.h should be renamed to pixman-common.h
> or pixman-inlines.h since it would no longer be specific to
> pixman-fast-path.c

That makes sense.

Best regards,
Siarhei Siamashka

More information about the Pixman mailing list