[Pixman] [PATCH 2/2] Fix for "syntax error: empty declaration" Solaris Studio warnings

Soeren Sandmann sandmann at cs.au.dk
Tue Jan 4 13:47:02 PST 2011

Siarhei Siamashka <siarhei.siamashka at gmail.com> writes:

> -MAKE_FETCHERS (none_r5g6b5,      r5g6b5,   PIXMAN_REPEAT_NONE);
> -MAKE_FETCHERS (reflect_r5g6b5,   r5g6b5,   PIXMAN_REPEAT_REFLECT);
> -MAKE_FETCHERS (normal_r5g6b5,    r5g6b5,   PIXMAN_REPEAT_NORMAL);
> +    MAKE_NEAREST_FETCHER (name, format, repeat_mode)			\
> +    MAKE_BILINEAR_FETCHER (name, format, repeat_mode)
> +
> +MAKE_FETCHERS (pad_a8r8g8b8,     a8r8g8b8, PIXMAN_REPEAT_PAD)
> +MAKE_FETCHERS (none_a8r8g8b8,    a8r8g8b8, PIXMAN_REPEAT_NONE)
> +MAKE_FETCHERS (reflect_a8r8g8b8, a8r8g8b8, PIXMAN_REPEAT_REFLECT)
> +MAKE_FETCHERS (normal_a8r8g8b8,  a8r8g8b8, PIXMAN_REPEAT_NORMAL)

I'm curious why this is better? It's not like the dummy variable
declarations show up in the binaries.

In any case, my only real concern was whether it would confuse emacs'
indenting algorithm. It seems to cope, so I'm fine with this.


More information about the Pixman mailing list