[Pixman] [PATCH] Improve handling of tangent circles

Siarhei Siamashka siarhei.siamashka at gmail.com
Fri Jan 14 02:10:21 PST 2011

On Wednesday 12 January 2011 23:58:55 Andrea Canciani wrote:
> On Wed, Jan 12, 2011 at 6:36 PM, Andrea Canciani <ranma42 at gmail.com> wrote:
> > Attached is a patch which adds radial-test to the GTK pixman tests.
> > I think we don't want it to be a checksum-based test because I believe
> > we can tolerate minor differences (caused by different rounding modes
> > or hardware where the float operations have slightly different error
> > propagation), but the aspect should basically be independent of this.
> > 
> > Please notice that the patch which started this thread changes the result
> > of the test. Without it, the radial gradient can in some cases also
> > include "negative radius" circles.
> I pushed the "Improve handling of tangent circles" patch to master.

OK. Thanks.

> Soren suggested some very useful improvements to radial-test, so
> here is an updated patch, which checks for division by 0 and does
> not use fmin/fmax.

I think we are on the right track here. Thanks for the test program. A
checksum-based test never was a requirement. I think it still would be
nice to make a non-GTK variant of this test so that it could run
automatically with 'make check' and also on http://tinderbox.x.org/
So that they will come after us if we break something in the future ;)

Best regards,
Siarhei Siamashka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/pixman/attachments/20110114/18cc433f/attachment.pgp>

More information about the Pixman mailing list