[Pixman] [PATCH 3/3] The code in 'bitmap_addrect' already assumes non-nortly reversed:ull 'reg->data'
sandmann at cs.au.dk
Fri Jan 14 07:22:38 PST 2011
Siarhei Siamashka <siarhei.siamashka at gmail.com> writes:
> Fair enough. An updated patch is attached.
> Does the patch itself look OK?
Yes, it looks good to me. As far as I can tell, this code:
> - if (!reg->data ||
> - reg->data->numRects == reg->data->size)
> + if (reg->data->numRects == reg->data->size)
cannot be reached without reg->data already having been derefenced
earlier in the function.
More information about the Pixman