[Pixman] [PATCH 1/2] sse2: if width == stride, convert to linear image

Soeren Sandmann sandmann at cs.au.dk
Fri May 6 00:18:51 PDT 2011


Chris Wilson <chris at chris-wilson.co.uk> writes:

> +    if (width == stride) {
> +	width *= height;
> +	height = 1;
> +    }

Do we need a check here that the mulitplication doesn't overflow?
pixman_multiply_overflows_int() can be used for that.

> +    if (width == src_stride && width == dst_stride) {
> +	    width *= height;
> +	    height = 1;
> +    }

Same here, and also braces go on their own line in pixman.

It would also be useful to have a brief comment in the commit log about
what a linear image is.


Soren


More information about the Pixman mailing list