[Pixman] pixman non POSIX test

Andrea Canciani ranma42 at gmail.com
Thu Nov 24 05:38:58 PST 2011


On Thu, Nov 24, 2011 at 3:47 AM, Naohiro Aota <naota at gentoo.org> wrote:
> pixman configure.ac has this line:
>
>   test "$test_CFLAGS" == "" &&         \
>
> which may cause an error on some POSIX shells.
>
> This can be fixed as the follwing like $MMX_CFLAGS is checked in the
> same file.
>
> I've also reported this to Bugzilla
> https://bugs.freedesktop.org/show_bug.cgi?id=42588

I tried your patch, pushed it to master and closed the bugreport.
Thanks!

Andrea

>
> diff --git a/configure.ac b/configure.ac
> index 0c23831..b851e96 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -150,7 +150,7 @@ AC_CHECK_DECL([__amd64], [AMD64_ABI="yes"], [AMD64_ABI="no"])
>  # if we're using Sun Studio and neither the user nor a config.site
>  # has set CFLAGS.
>  if test $SUNCC = yes &&                        \
> -   test "$test_CFLAGS" == "" &&                \
> +   test "x$test_CFLAGS" = "x" &&               \
>    test "$CFLAGS" = "-g"
>  then
>   CFLAGS="-O -g"
> _______________________________________________
> Pixman mailing list
> Pixman at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/pixman
>


More information about the Pixman mailing list