[Pixman] [PATCH 0/5] Simple repeat

Chris Wilson chris at chris-wilson.co.uk
Fri Sep 2 03:01:22 PDT 2011

On Tue, 30 Aug 2011 21:48:36 +0900, Taekyun Kim <podain77 at gmail.com> wrote:
> From: Taekyun Kim <tkq.kim at samsung.com>
> I modified previous simple repeat patches for ARM backend to cover other
> backends. Soren suggested a good point of handling different backends
> at common place. We can look up COVER_CLIP composite functions and
> stitch source scanlines to support PIXMAN_REPEAT_NORMAL.

Tested using cairo-test-suite. At least in those simple scenarios it works
well. Now we just need an extension to non-identity transforms ;-)

> One thing that I concern is that if we get general_composite_rect() from
> lookup, is it beneficial to do stitching? general_composite_rect() itself
> can handle normal repeat. So we might get regressions. And if we write
> good fetchers for normal repeat, it might be good to bypass repeat
> handling to general_composite_rect(). We can also bypass repeat handling
> if the composite function can handle the repeat.

We can always adjust the preferred path by adding higher priority
fast-paths.  I suspect that we may wish to encode more information from
profiling about which are the best paths to take, which will also
probably merit a more complicated lookup mechanism for fast paths. And
one day somebody will come up with a JIT code-generator that is equal to
the hand-written routines and fast enough to be used inline...

Chris Wilson, Intel Open Source Technology Centre

More information about the Pixman mailing list