[Pixman] [PATCH 0/11] Use macros to generate fetchers

Soeren Sandmann sandmann at cs.au.dk
Tue Sep 13 13:51:44 PDT 2011


Soeren Sandmann <sandmann at cs.au.dk> writes:

> Chris Wilson <chris at chris-wilson.co.uk> writes:
>
>> The final patch is a little scary though. Was that motivated by
>> observation of the generated assembly or through performance testing?
>
> It was motivated by looking at the generated assembly, but I'll run some
> performance tests. 

Performance results below. I tested master, the series without the final
fast path patch, and the series with the final patch. The results are
that "without" wins 10/26, "master" 9/26, and "fast paths" 7/26, but
there is never a huge difference.

I guess the conclusion is that the fast paths can't be justified by
these measurements.


Soren

                                             minimum   median  std.dev.         winner
--------------------------------------------------------------------------------------- 
[  0]    image            firefox-talos-gfx   21.013   21.058   0.11%    6/6	without
[  0]    image            firefox-talos-gfx   20.714   20.790   0.27%    6/6
[  0]    image            firefox-talos-gfx   21.249   21.312   0.15%    6/6
---------------------------------------------------------------------------------------
[  0]  image16            firefox-talos-gfx   19.623   19.630   0.04%    5/6	without
[  0]  image16            firefox-talos-gfx   19.596   19.618   0.14%    6/6
[  0]  image16            firefox-talos-gfx   19.925   19.948   0.12%    6/6
---------------------------------------------------------------------------------------
[  0]    image            firefox-talos-svg  120.890  121.006   0.07%    5/6	without
[  0]    image            firefox-talos-svg  120.623  120.647   0.03%    5/6
[  0]    image            firefox-talos-svg  120.978  121.055   0.04%    5/6
---------------------------------------------------------------------------------------
[  0]  image16            firefox-talos-svg  138.907  139.182   0.12%    5/6	master
[  0]  image16            firefox-talos-svg  140.011  140.043   0.04%    5/6
[  0]  image16            firefox-talos-svg  139.609  139.825   0.08%    5/6
---------------------------------------------------------------------------------------
[  0]    image                    evolution   25.322   25.456   0.27%    6/6	without
[  0]    image                    evolution   25.248   25.414   0.27%    6/6
[  0]    image                    evolution   26.654   26.732   0.15%    6/6
---------------------------------------------------------------------------------------
[  0]  image16                    evolution   13.096   13.165   0.51%    6/6	master
[  0]  image16                    evolution   13.217   13.250   0.17%    5/6
[  0]  image16                    evolution   13.368   13.435   0.26%    6/6
---------------------------------------------------------------------------------------
[  0]    image         gnome-system-monitor   10.192   10.222   0.13%    6/6	without
[  0]    image         gnome-system-monitor   10.166   10.195   0.13%    6/6
[  0]    image         gnome-system-monitor   10.488   10.499   0.12%    6/6
---------------------------------------------------------------------------------------
[  0]  image16         gnome-system-monitor   10.210   10.255   0.34%    6/6	without
[  0]  image16         gnome-system-monitor   10.191   10.236   0.34%    6/6
[  0]  image16         gnome-system-monitor   10.503   10.537   0.40%    6/6
---------------------------------------------------------------------------------------
[  0]    image           gnome-terminal-vim    6.547    6.692   0.92%    6/6	master
[  0]    image           gnome-terminal-vim    6.992    7.098   1.07%    6/6
[  0]    image           gnome-terminal-vim    6.722    6.864   1.17%    6/6
---------------------------------------------------------------------------------------
[  0]  image16           gnome-terminal-vim    6.104    6.242   0.95%    6/6	fast paths
[  0]  image16           gnome-terminal-vim    6.175    6.271   0.74%    6/6
[  0]  image16           gnome-terminal-vim    6.043    6.141   0.79%    6/6
---------------------------------------------------------------------------------------
[  0]    image               grads-heat-map    0.552    0.561   0.85%    6/6	master
[  0]    image               grads-heat-map    0.578    0.584   0.48%    6/6
[  0]    image               grads-heat-map    0.558    0.568   0.80%    6/6
---------------------------------------------------------------------------------------
[  0]  image16               grads-heat-map    0.556    0.559   0.56%    6/6	master
[  0]  image16               grads-heat-map    0.575    0.576   0.07%    4/6
[  0]  image16               grads-heat-map    0.558    0.561   0.27%    6/6
---------------------------------------------------------------------------------------
[  0]    image                         gvim   32.374   32.459   0.15%    6/6	fast paths
[  0]    image                         gvim   32.414   32.505   0.11%    6/6
[  0]    image                         gvim   32.343   32.357   0.03%    5/6
---------------------------------------------------------------------------------------
[  0]  image16                         gvim   17.770   17.899   0.35%    6/6	without
[  0]  image16                         gvim   17.632   17.653   0.06%    5/6
[  0]  image16                         gvim   17.637   17.753   0.42%    6/6
---------------------------------------------------------------------------------------
[  0]    image                midori-zoomed    8.830    8.837   0.05%    5/6	without
[  0]    image                midori-zoomed    8.678    8.686   0.19%    5/6
[  0]    image                midori-zoomed    8.629    8.740   0.51%    6/6
---------------------------------------------------------------------------------------
[  0]  image16                midori-zoomed    9.453    9.481   0.15%    6/6	fast paths
[  0]  image16                midori-zoomed    9.512    9.592   0.38%    6/6
[  0]  image16                midori-zoomed    9.407    9.425   0.08%    6/6
---------------------------------------------------------------------------------------
[  0]    image                    ocitysmap    4.925    5.002   0.76%    6/6	fast paths
[  0]    image                    ocitysmap    4.750    4.893   1.73%    6/6
[  0]    image                    ocitysmap    4.660    4.796   1.42%    6/6
---------------------------------------------------------------------------------------
[  0]  image16                    ocitysmap    4.901    4.966   0.85%    6/6	fast paths
[  0]  image16                    ocitysmap    4.736    4.836   1.29%    6/6
[  0]  image16                    ocitysmap    4.702    4.736   0.85%    6/6
---------------------------------------------------------------------------------------
[  0]    image                      poppler    4.864    4.982   1.17%    6/6	without
[  0]    image                      poppler    4.796    4.820   0.96%    6/6
[  0]    image                      poppler    4.735    4.852   1.18%    6/6
---------------------------------------------------------------------------------------
[  0]  image16                      poppler    4.859    4.874   0.93%    6/6	fast paths
[  0]  image16                      poppler    4.788    4.885   0.99%    6/6
[  0]  image16                      poppler    4.724    4.755   1.03%    6/6
---------------------------------------------------------------------------------------
[  0]    image           swfdec-giant-steps    4.418    4.463   1.27%    6/6	master
[  0]    image           swfdec-giant-steps    4.415    4.531   1.07%    6/6
[  0]    image           swfdec-giant-steps    4.383    4.524   1.70%    6/6
---------------------------------------------------------------------------------------
[  0]  image16           swfdec-giant-steps    7.837    7.846   0.07%    5/6	master
[  0]  image16           swfdec-giant-steps    7.750    7.857   0.65%    6/6
[  0]  image16           swfdec-giant-steps    7.785    7.889   0.61%    6/6
---------------------------------------------------------------------------------------
[  0]    image               swfdec-youtube    7.984    8.094   0.62%    6/6	master
[  0]    image               swfdec-youtube    8.057    8.068   0.07%    4/6
[  0]    image               swfdec-youtube    8.042    8.055   0.08%    5/6
---------------------------------------------------------------------------------------
[  0]  image16               swfdec-youtube   11.960   11.980   0.10%    6/6	master
[  0]  image16               swfdec-youtube   12.066   12.107   0.14%    6/6
[  0]  image16               swfdec-youtube   12.001   12.005   0.03%    5/6
---------------------------------------------------------------------------------------
[  0]    image            xfce4-terminal-a1    6.059    6.178   0.87%    6/6	fast paths
[  0]    image            xfce4-terminal-a1    6.133    6.223   0.80%    6/6
[  0]    image            xfce4-terminal-a1    5.815    5.917   0.89%    6/6
---------------------------------------------------------------------------------------
[  0]  image16            xfce4-terminal-a1    6.382    6.477   0.69%    6/6	without
[  0]  image16            xfce4-terminal-a1    5.705    5.816   1.04%    6/6
[  0]  image16            xfce4-terminal-a1    6.204    6.309   0.75%    6/6
---------------------------------------------------------------------------------------


More information about the Pixman mailing list