[Pixman] [PATCH] MIPS: DSPr2: Added over_n_8_8888 and over_n_8_0565 fast paths.
nlukic at mips.com
Sun Apr 22 11:03:35 PDT 2012
Siarhei has a good point here. That part of code can be improved more.
I'll upload a new patch that includes this comment from Siarhei.
From: Søren Sandmann [mailto:sandmann at cs.au.dk]
Sent: Friday, April 20, 2012 4:12 PM
To: Siarhei Siamashka
Cc: Lukic, Nemanja; pixman at lists.freedesktop.org; nemanja.lukic at rt-rk.com
Subject: Re: [Pixman] [PATCH] MIPS: DSPr2: Added over_n_8_8888 and over_n_8_0565 fast paths.
Siarhei Siamashka <siarhei.siamashka at gmail.com> writes:
>> + /* a1 = src */
>> + lbu t0, 0(a2) /* t0 = mask */
>> + beqz t0, 222f /* if (t0 == 0) */
>> + addiu a2, a2, 1
>> + beq t0, t5, 22f /* if (t0 == 0xff) */
>> + move t1, a1
>> + lhu t1, 0(a0) /* t1 = dst */
>> + CONVERT_1x0565_TO_1x8888 t1, t2, t3, t7
>> + OVER_8888_8_8888 a1, t0, t2, t1, t4, t3, t7, t8, t9
>> + CONVERT_1x8888_TO_1x0565 t1, t9, t3, t7
> I think this can be improved a bit. When (srca == 0xff && mask ==
> 0xff) there is no need to do 8888 to 0565 conversion on each
> iteration, it can be done once.
Nemanja, any comments on this?
More information about the Pixman