[Pixman] pixman on iOS

Siarhei Siamashka siarhei.siamashka at gmail.com
Sat Dec 1 17:03:31 PST 2012

On Wed, 28 Nov 2012 12:00:39 -0800
Jeremy Huddleston Sequoia <jeremyhu at apple.com> wrote:

> On Nov 28, 2012, at 11:52 AM, Siarhei Siamashka <siarhei.siamashka at gmail.com> wrote:
> > Now it appears that this bug also affects mingw-w64, not just clang:
> >    https://bugs.freedesktop.org/show_bug.cgi?id=57591
> > 
> > I have sent a patch to change the order of checks, but another option
> > to evaluate is to revert a069da6c66da407cc52e1e92321d69c68fd6beb5.
> > 
> > Jeremy, it might look like I'm picking on you, but it would really help
> > to get a confirmation that a069da6c66da407cc52e1e92321d69c68fd6beb5
> > actually fixed some real problem on iOS. The commit message was a bit
> > vague. Shit happens, I guess nobody here could have predicted that
> > __declspec generally has such a weird behavior in modern compilers and
> > everyone had time to review your patch before it got pushed. So it
> > is not like you are the one to blame.
> Oh, and yes a069da6c66da407cc52e1e92321d69c68fd6beb5 did fix a real
> problem caught by tinderbox.  pixman was failing to compile on my OS X
> clang tinderbox.  I'm not sure why you asked specifically about iOS,
> but yes, it would fix the same failure building for iOS as it fixed
> building for OS X.

It was just to make sure that __declspec is really the only way to get
TLS on iOS.  And not, for example, the case when both __thread and
__declspec(thread) are supported, with the latter being just officially
preferred or something like this. You commit message for a similar
patch in xserver mentioned silencing warnings. And this got me confused.

If there are no objections and nobody suggests a better patch within a
few days, I guess we can just apply:

Best regards,
Siarhei Siamashka

More information about the Pixman mailing list