[Pixman] [PATCH 1/5] ARMv6: Makefile change for new source files

Siarhei Siamashka siarhei.siamashka at gmail.com
Thu Dec 27 04:13:44 PST 2012


On Fri, 21 Dec 2012 18:48:21 -0000
"Ben Avison" <bavison at riscosopen.org> wrote:

> diff --git a/pixman/Makefile.am b/pixman/Makefile.am
> index cbed085..30da833 100644
> --- a/pixman/Makefile.am
> +++ b/pixman/Makefile.am
> @@ -58,7 +58,9 @@ noinst_LTLIBRARIES += libpixman-arm-simd.la
>   libpixman_arm_simd_la_SOURCES = \
>   	pixman-arm-simd.c	\
>   	pixman-arm-common.h	\
> -	pixman-arm-simd-asm.S
> +	pixman-arm-simd-asm.S   \
> +	pixman-arm-simd-asm-scaled.S \
> +	pixman-arm-simd-asm.h
>   libpixman_1_la_LIBADD += libpixman-arm-simd.la
> 
>   ASM_CFLAGS_arm_simd=

If I understand it right, in this first patch you are referencing to
still non-existing files (added in next patches). This does not seem to
be a good idea, because pixman is expected to compile cleanly after
every commit.

-- 
Best regards,
Siarhei Siamashka


More information about the Pixman mailing list