[Pixman] [PATCH] pixman-image.c: Fix typo in pixman_image_set_transform()

Søren Sandmann sandmann at cs.au.dk
Thu Jan 5 07:42:19 PST 2012


From: Søren Sandmann Pedersen <ssp at redhat.com>

A parenthesis was misplaced so that the size argument to memcmp() was
always 0. The bug is harmless except that the flags might be
unnecessarily recomputed in some cases.

A bug reporting this in Mozilla's fork was discovered here:

    https://bugzilla.mozilla.org/show_bug.cgi?id=710992
---
 pixman/pixman-image.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/pixman/pixman-image.c b/pixman/pixman-image.c
index 913853c..ad5996b 100644
--- a/pixman/pixman-image.c
+++ b/pixman/pixman-image.c
@@ -631,7 +631,7 @@ pixman_image_set_transform (pixman_image_t *          image,
     }
 
     if (common->transform &&
-	memcmp (common->transform, transform, sizeof (pixman_transform_t) == 0))
+	memcmp (common->transform, transform, sizeof (pixman_transform_t)) == 0)
     {
 	return TRUE;
     }
-- 
1.7.4



More information about the Pixman mailing list