[Pixman] Patches to add Visual C++ 2008/2010 project files to compile pixman-master

Søren Sandmann sandmann at cs.au.dk
Tue May 8 08:05:47 PDT 2012


"Fan, Chun-wei (范君維)" <fanc999 at gmail.com> writes:

> I have managed to come up with some patches to add Visual C++
> 2008/2010 project files to build pixman as a DLL with these compilers
> under x86 and x86-64 configurations, with x86-MMX support (on x86
> only) and SSE2 support.
>
> In the first patch:
> -Updated pixman.h to have public functions decorated with
> pixman_public (like what is now done in Cairo) to export/import
> functions when pixman is built as a DLL on Visual C++ (this does not
> affect the build on other compilers).

This causes the formatting in pixman.h to be completely broken.

If we are going to need these pixman_public annotations, please come up
with a way to format the file to incorporate them. Alternatively, maybe
we could use .DEF files instead?

> -Did the projects like what is now done in the GLib etc, where the
> source file listing for the source files to compile is completed
> during "make dist" by reading from the source listing from
> Makefile.sources, which will simplify maintenance of the project files
> as source files could be added or removed.
>
> In the second patch:
> -Have the .sln files to be in Windows/DOS EOL so that they will work
> correctly.

As far as I can tell, this patch doesn't actually do anything,
presumably because some email system stripped out the Windows
newlines. I can run the .sln files through unix2dos before pushing if
that's easier than trying to send CRLF characters through email.

As an aside, is there a reason to have the newline changes in a separate
patch?


Soren


More information about the Pixman mailing list