[Pixman] [PATCH 2/2] MIPS: DSPr2: Added bilinear over_8888_8_8888 fast path.

[Søren Sandmann]

Siarhei Siamashka <siarhei.siamashka at gmail.com> writes:

> On Wed, May 16, 2012 at 12:37 AM, Siarhei Siamashka
> <siarhei.siamashka at gmail.com> wrote:
>> On Mon, May 14, 2012 at 9:17 PM, Nemanja Lukic <nemanja.lukic at rt-rk.com> wrote:
>>> Is this small improvement worth making this code vulnerable to endian issues?
>>
>> If you are already satisfied with this level of performance, then it's
>> probably fine for now.
>
> By the way, I really mean it :) In my opinion, it is generally enough
> that the patches are useful for something and do not cause
> regressions. If implementing additional performance tweaks may take
> too much time, then they can be added later. But it is also important
> to realize that there is still some room for improvement and not to
> drop the optimization work half-way.
>
> Also maybe you have noticed that pixman-0.26.0 is about to be released
> next week:
>     http://lists.freedesktop.org/archives/pixman/2012-May/001969.html
> We still need to either fix the bug which causes the test suite
> failure for MIPS DSP ASE. Or at least disable problematic
> optimizations for this stable release.

Yeah, unless someone who understands the fix here:

   http://lists.freedesktop.org/archives/pixman/2012-May/001932.html

comes up with a commit message, I'll just revert the optimization before
releasing.


Søren