[Pixman] [PATCH 2/2] MIPS: DSPr2: Added bilinear over_8888_8_8888 fast path.
nlukic at mips.com
Wed May 23 10:46:03 PDT 2012
Your comments for the bilinear commit are truly worth a lot more investigation, and you did made a strong point that these optimizations should be revisited.
But, for now, these tweaks do need much time to implement, and may also influence not only bilinear commit.
Since I do plan to push more fast paths (both bilinear, and SRC/OVER/ADD) for MIPS DSP, I thinks we should use this bilinear patch as-it-is for now (for this pixman release),
since it shows good performance increase, and doesn't show any regressions, but for sure I'll come back with new commit that will include tweaks you suggested, and improve existing commit(s).
From: pixman-bounces+nlukic=mips.com at lists.freedesktop.org [mailto:pixman-bounces+nlukic=mips.com at lists.freedesktop.org] On Behalf Of Siarhei Siamashka
Sent: Sunday, May 20, 2012 11:31 PM
To: nemanja.lukic at rt-rk.com
Cc: pixman at lists.freedesktop.org
Subject: Re: [Pixman] [PATCH 2/2] MIPS: DSPr2: Added bilinear over_8888_8_8888 fast path.
On Wed, May 16, 2012 at 12:37 AM, Siarhei Siamashka
<siarhei.siamashka at gmail.com> wrote:
> On Mon, May 14, 2012 at 9:17 PM, Nemanja Lukic <nemanja.lukic at rt-rk.com> wrote:
>> Is this small improvement worth making this code vulnerable to endian issues?
> If you are already satisfied with this level of performance, then it's
> probably fine for now.
By the way, I really mean it :) In my opinion, it is generally enough
that the patches are useful for something and do not cause
regressions. If implementing additional performance tweaks may take
too much time, then they can be added later. But it is also important
to realize that there is still some room for improvement and not to
drop the optimization work half-way.
Also maybe you have noticed that pixman-0.26.0 is about to be released
We still need to either fix the bug which causes the test suite
failure for MIPS DSP ASE. Or at least disable problematic
optimizations for this stable release.
Pixman mailing list
Pixman at lists.freedesktop.org
More information about the Pixman