[Pixman] [PATCH 3/8] MIPS: MIPS32r2: Basic infrastructure for MIPS32r2 optimizations

Søren Sandmann sandmann at cs.au.dk
Wed Aug 21 14:11:13 PDT 2013


I think this patch could this still benefit from being broken into smaller
bits -- it looks to me like it is still both adding new code and moving old
code around at the same time.

I'd suggest breaking it into at least two separate patches where the first
one adds an empty MIPSr2 implementation that doesn't do anytning, and the
second one then moves the various fast paths from the current dspr2
implementation into the mips2r2 one. A third one can then add any new
MIPSr2 patches.

This way, it's easy to see what code needs careful review, and which code
can be assumed to already work well.

I also have some specific comments on the changes to the pixman-mips.c
file, but I'd rather wait with those until those changes are available in a
smaller patch.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pixman/attachments/20130821/8503ea4a/attachment.html>

More information about the Pixman mailing list