[Pixman] mips* asm exports symbols that should not export

[Nemanja Lukic]

Hi YunQiang Su,

Attached is solution for unwanted symbol visibility.
I'll upstream both patches soon.

Thanks,
Nemanja Lukic

-----Original Message-----
From: Nemanja Lukic [mailto:nemanja.lukic at rt-rk.com] 
Sent: Thursday, December 19, 2013 12:30 PM
To: 'Yunqiang Su'
Cc: 'pixman at lists.freedesktop.org'
Subject: RE: [Pixman] mips* asm exports symbols that should not export

Hi YunQiang Su,

Yes, if you use mips32r2 option to build for o32, these symbols will be
exported (since optimizations will be compiled).
And, once again, you are right, these symbols are internal API and shouldn't
be exported. We need to fix this.

I'm maintaining MIPS optimizations for Pixman repository, so I'll take a
look, and try to fix this.

Thanks for your observations,
Nemanja Lukic

-----Original Message-----
From: Yunqiang Su [mailto:wzssyqa at gmail.com]
Sent: Thursday, December 19, 2013 10:36 AM
To: Nemanja Lukic
Cc: pixman at lists.freedesktop.org
Subject: Re: [Pixman] mips* asm exports symbols that should not export

On Thu, Dec 19, 2013 at 5:20 PM, Nemanja Lukic <nemanja.lukic at rt-rk.com>
wrote:
> Hi YunQiang Su,
>
> Yes, you are right, these symbols shouldn't be exported.
> This is due to the fact that some optimizations were compiled (not
> executed)

With this patch, if I use mips32r2 option to build for o32, will these
symbols still be export?

As I understand, these symbols are internal APIs while should never be
export.
Are them?


> where they shouldn't.
> Please find attached fix, that solves this issue.
>
> In the mean time I'll submit this patch on main pixman repository.
>
> Thanks and sorry for late reply,
> Nemanja Lukic
>
> -----Original Message-----
> From: pixman-bounces at lists.freedesktop.org
> [mailto:pixman-bounces at lists.freedesktop.org] On Behalf Of YunQiang Su
> Sent: Saturday, December 7, 2013 5:57 PM
> To: pixman at lists.freedesktop.org
> Subject: [Pixman] mips* asm exports symbols that should not export
>
> Hi, folks,
>
> When build pixman with mips64r2 options, I get some addational symbols 
> export, while they were supposed not to be export.
>
> More details can be found in:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=719059
>
> The build log can be found from:
>     
> http://mips64el.debian.net/attempted/pixman_0.30.2-2_mips64el.build.xz
>
> --
> YunQiang Su
> _______________________________________________
> Pixman mailing list
> Pixman at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/pixman



--
Yunqiang Su
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-MIPS-Fix-exported-symbols-in-public-API.PATCH
Type: application/octet-stream
Size: 868 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/pixman/attachments/20131219/3cee7f0a/attachment.obj>