[Pixman] [PATCH] bits: Special case src_iter for 1x1R images

Søren Sandmann sandmann at cs.au.dk
Sun Jan 6 08:34:59 PST 2013


Chris Wilson <chris at chris-wilson.co.uk> writes:

> These are often used inplace of a solid-fill gradient, with the
> expectation that have similar performance and hit the same fast paths.
> One exception is the identification of the 1x1R <-> solid-fill
> equivalence in general_composite_rect(). By adding the special case to
> _pixman_bits_image_src_iter_init, we can recover the lost performance:

This issue is also fixed by the patch here:

    http://lists.freedesktop.org/archives/pixman/2012-December/002444.html

which I will push shortly (with an updated commit message that includes
similar performance numbers to those you posted).

Doing it in the noop implementation is better because it avoids the
question of, say, a repeating SSE2 iterator potentially getting picked
before the one in pixman-bits-image.c.


Søren


More information about the Pixman mailing list