[Pixman] [PATCH 1/4] bits: Implement PAD support in the simple fetcher

Jeff Muizelaar jmuizelaar at mozilla.com
Wed Jan 30 21:21:52 PST 2013


On 2013-01-30, at 9:14 PM, Søren Sandmann wrote:

> 
>> Obviously this means that in this case, we're not getting the benefits of
>> any platform-specific fast paths. Perhaps what we need is a "pad"
>> equivalent of fast_composite_tiled_repeat()?
> 
> This might be a good idea, though it's still worth finding out what is
> causing an untransformed image with PAD repeat to be drawn without a
> mask onto a destination bigger than source image. Either the resulting
> stripes are desirable for some reason, or Firefox should be more careful
> about clipping to the source image.

I've I had to guess, I'd guess that this is unintentional. There's been a bunch
of churn over the semantics drawImage with source rect larger than the image. At one
time, the correct behaviour was to use EXTEND_PAD however I believe
the currently spec'd behaviour is that the we should be clamping the source rect to the
size of the image. I'm not sure we've switched to this yet, but I'll take a look tomorrow.

-Jeff


More information about the Pixman mailing list