[Pixman] [PATCH 3/3] Add an iterator that can fetch bilinearly scaled images

Chris Wilson chris at chris-wilson.co.uk
Mon Jul 29 10:44:00 PDT 2013

On Mon, Jul 29, 2013 at 05:03:29AM -0400, Søren Sandmann Pedersen wrote:
> This new iterator works in a separable way; that is, for a destination
> scaline, it scales the two involved source scanlines and then caches
> them so that they can be reused for the next destination scanlines.

Series was very readable. Just found one minor comment.

> +fail:
> +    /* Something went wrong, either a bad matrix or OOM; in such cases,
> +     * we don't guarantee any particular rendering.
> +     */
> +    iter->get_scanline = _pixman_iter_get_scanline_noop;
> +    iter->fini = bilinear_cover_iter_fini;

_pixman_log_error (FUNC, "Allocation failure, skipping rendering\n");

Just a suggestion, as I am not sure if they are even worth logging.

Chris Wilson, Intel Open Source Technology Centre

More information about the Pixman mailing list