[Pixman] [PATCH 2/2] MIPS: DSPr2: Added more fast-paths for SRC operation: - src_0888_8888_rev - src_0888_0565_rev

Søren Sandmann sandmann at cs.au.dk
Wed Mar 6 16:15:23 PST 2013

Nemanja Lukic <nlukic at mips.com> writes:

> Performance numbers before/after on MIPS-74kc @ 1GHz:
> lowlevel-blt-bench results

I realize you already pushed these to master (which is fine, people had
enough time to comment), but I still have a few questions and comments.

One nitpick about commit messages: Would you mind putting each fast path
in its own commit and making the first line of each commit message
shorter than 72 characters. That is, for this patch, break it into two
patches with these titles:

        - MIPS: DSPr2: Added src_0888_8888_rev fast path
        - MIPS: DSPr2: Added src_0888_565_rev fast path

That makes the release announcements easier to read and may also help a
bit with bisecting.

Regarding this patch itself, I'm curious where these operations are
used? As far as I know, X and cairo don't really use the 0888 format for
anything, and surely swizzling the colors would be even rarer?

Also, as with the pixbuf patches, if you are going to refer to
lowlevel-blt results, I think support should be added for those
operations first in a separate patch.


More information about the Pixman mailing list