[Pixman] [PATCH] test/utils.c: Make the stack unaligned only on 32 bit Windows

John Emmas johne53 at tiscali.co.uk
Sun Nov 17 02:00:37 PST 2013


I'm not sure if there's a connection here or if it's just a coincidence 
but in a completely separate library (libffi) I noticed a very recent 
commit by Mark Kettenis (6th Nov 2013) which he describes as "Align the 
stack pointer to 16-bytes".  Unfortunately, his change is in an assembly 
language module which I cant profess to understand.  Is anyone here 
qualified to check the git log for libffi to find out if Mark's arrived 
at the same flawed conclusion about stack alignment or if (in his case) 
there's a valid reason for setting 16-byte alignment?

Assuming there isn't, I don't mind joining the mailing list for libffi 
and bringing their attention to the points you guys are discussing 
here.  I presume that if 16-byte alignment isn't universally valid for 
pixman it probably isn't valid for other libraries either?

John


More information about the Pixman mailing list