[Pixman] [PATCH 2/2] test: Add new thread-test program

Siarhei Siamashka siarhei.siamashka at gmail.com
Wed Oct 9 08:12:32 PDT 2013

On Wed, 09 Oct 2013 17:06:06 +0200
sandmann at cs.au.dk (Søren Sandmann) wrote:

> Andrea Canciani <ranma42 at gmail.com> writes:
> > Sorry, I didn't realize it beforehand, but I just noticed that thread-test
> > fails on MacOS.
> > This happens because it relies on the availability of OpenMP to have a
> > thread-local state for the prng.
> > Would it be ok to have each thread explicitly keep the state of its prng or
> > is this another element that the test is supposed to be checking?
> It's not intended to test the thread-private-ness of the prng states, so
> yes, the simplest fix seems to be to just explicitly keep a prng_t
> for each thread.

Would it really help to pass the test? The fast path cache is using the
thread-local storage too.

Best regards,
Siarhei Siamashka

More information about the Pixman mailing list