[Pixman] [patch] fd.o bz# Bug 67484 - Corrupted CustomShape crashes Xorg

Søren Sandmann sandmann at cs.au.dk
Wed Oct 23 14:37:03 PDT 2013

Ritesh Khadgaray <ritesh.khadgaray at canonical.com> writes:

>   Updated , the test case as a separate patch.

Thanks, that's an improvement. However,

- You overwrite the existing trapezoid test. It would be better to
  extend the array so that both trapezoids are tested.

- The commit messages should explain what you are doing and why. In
  particular the summary line should be a summary of what's going
  on. Please look at the other commit messages in the pixman repository
  to see what a good one looks like.

- Please send the patches using "git format-patch". That way they can be
  applied directly to the source tree along with the commit message.


More information about the Pixman mailing list