[Pixman] [PATCH 0/3] Test negative strides

Siarhei Siamashka siarhei.siamashka at gmail.com
Fri Sep 27 14:57:44 PDT 2013


On Fri, 27 Sep 2013 23:18:36 +0200
sandmann at cs.au.dk (Søren Sandmann) wrote:

> Siarhei Siamashka <siarhei.siamashka at gmail.com> writes:
> 
> >> > But something unexpectedly broke on PowerPC and maybe other big
> >> > endian systems after the following commit:
> >> >     http://cgit.freedesktop.org/pixman/commit/?id=aa5c45254eb60ce4
> >> 
> >> Looks like I forgot to fix up image_endian_swap() to cope with negative
> >> strides. I don't have easy access to a PowerPC at the moment, so if you
> >> can test the following patch, that would be helpful.
> >> 
> >> Also available here:
> >> 
> >>      http://cgit.freedesktop.org/~sandmann/pixman/log/?h=negative-strides
> >
> > Thanks, this makes sense. But looks like there is something else still
> > broken there.
> 
> Somehow I missed the "case 16:" case. New patch below; also available in
> the negative-strides branch of my repository on fd.o.

Thanks, this works. I have just independently found the same problem,
but was running some additional tests.

By the way, print_image() does not behave in the same way on big and
little endian systems, which makes debugging a little bit more
difficult.

-- 
Best regards,
Siarhei Siamashka


More information about the Pixman mailing list