[Pixman] [PATCH 2/2] test: Add new thread-test program

[Søren Sandmann]

Lennart Sorensen <lsorense at csclub.uwaterloo.ca> writes:

>> diff --git a/test/Makefile.am b/test/Makefile.am
>> index 5d901d5..80f3537 100644
>> --- a/test/Makefile.am
>> +++ b/test/Makefile.am
>> @@ -1,8 +1,8 @@
>>  include $(top_srcdir)/test/Makefile.sources
>>  
>> -AM_CFLAGS = $(OPENMP_CFLAGS)
>> -AM_LDFLAGS = $(OPENMP_CFLAGS) $(TESTPROGS_EXTRA_LDFLAGS)
>> -LDADD = libutils.la $(top_builddir)/pixman/libpixman-1.la -lm  $(PNG_LIBS)
>> +AM_CFLAGS = $(OPENMP_CFLAGS) $(PTHREAD_CFLAGS)$
> What is that trailing '$' for?

It's just a typo; I'll fix before pushing.

In your other mail, the thread-test was skipped because pthreads were
not detected. Do you happen to know why? The first patch [1] that adds
pthread detection had a bug where it doesn't export the PTHREAD_CFLAGS
to the Makefiles, but that should at most cause build failures; it
shouldn't cause thread-test to be skipped since HAVE_PTHREADS would
still be defined.


Søren


[1] http://lists.freedesktop.org/archives/pixman/2013-September/002975.html