[Pixman] [PATCH 05/11] MIPS: mips32r2: empty implementation with runtime detection

Søren Sandmann soren.sandmann at gmail.com
Fri Apr 11 12:20:38 PDT 2014


This needs more information in the commit message. See f179263 for an
example of the level of information that should ideally be there.

Otherwise this patch looks reasonable to me, though as Siarhei noted, it
seems a little silly to add all those entirely empty files. But
whatever.


Søren


Nemanja Lukic <nemanja.lukic at rt-rk.com> writes:

> ---
>  configure.ac                    |   39 +++++++++++++++++++++++++++++
>  pixman/Makefile.am              |   20 +++++++++++++--
>  pixman/pixman-mips-common-asm.h |   35 ++++++++++++++++++++++++++
>  pixman/pixman-mips-common.h     |   35 ++++++++++++++++++++++++++
>  pixman/pixman-mips-dspr2-asm.S  |    2 +-
>  pixman/pixman-mips-dspr2-asm.h  |    2 +-
>  pixman/pixman-mips-dspr2.c      |    2 +-
>  pixman/pixman-mips.c            |   26 +++++++++++++++++++-
>  pixman/pixman-mips32r2-asm.S    |   30 +++++++++++++++++++++++
>  pixman/pixman-mips32r2-asm.h    |   35 ++++++++++++++++++++++++++
>  pixman/pixman-mips32r2.c        |   51 +++++++++++++++++++++++++++++++++++++++
>  pixman/pixman-private.h         |    5 ++++
>  12 files changed, 275 insertions(+), 7 deletions(-)
>  create mode 100644 pixman/pixman-mips-common-asm.h
>  create mode 100644 pixman/pixman-mips-common.h
>  create mode 100644 pixman/pixman-mips32r2-asm.S
>  create mode 100644 pixman/pixman-mips32r2-asm.h
>  create mode 100644 pixman/pixman-mips32r2.c
>
> diff --git a/configure.ac b/configure.ac
> index 5229032..230633d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -716,6 +716,45 @@ fi
>  AM_CONDITIONAL(USE_ARM_IWMMXT, test $have_iwmmxt_intrinsics = yes)
>  
> [...]


More information about the Pixman mailing list