[Pixman] [PATCH] armv7: Re-use existing fast paths in more cases

Pekka Paalanen ppaalanen at gmail.com
Wed Apr 22 04:43:42 PDT 2015

On Tue, 21 Apr 2015 01:14:09 +0100
Ben Avison <bavison at riscosopen.org> wrote:

> There are a group of combiner types - SRC, OVER_REVERSE, IN, OUT and ADD -
> where the source alpha affects only the destination alpha component. This
> means that any fast path with a8r8g8b8 source and destination can also be
> applied to an equivalent operation with x8r8g8b8 source and destination
> just by updating the fast path table, and likewise with a8b8g8r8 and
> x8b8g8r8. The following operations are affected:
> add_x888_8_x888   (and bilinear scaled version of same)
> add_x888_8888_x888
> add_x888_n_x888
> add_x888_x888     (and bilinear scaled version of same)
> ---
>  pixman/pixman-arm-neon.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)


just a comment for the future: this and the previous patch have
identical summaries (subject line). First I thought they are the same
patch revised or double-sent, but they are indeed different patches.

Could you replace, say, "in more cases" with a few words making the
summaries unique if you need to re-send these?

FYI, Patchwork has been set up, but not seeded with old emails yet:

I'll try to manage it personally until I make the proper announcement
with instructions and all.


More information about the Pixman mailing list