[Pixman] [PATCH v3] test: Add a new benchmarker targeting affine operations
Pekka Paalanen
ppaalanen at gmail.com
Mon Apr 27 01:57:47 PDT 2015
On Fri, 24 Apr 2015 10:25:05 +0300
Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Thu, 23 Apr 2015 20:28:58 +0100
> "Ben Avison" <bavison at riscosopen.org> wrote:
>
> > On Thu, 23 Apr 2015 13:10:10 +0100, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> >
> > > Affine-bench differs from lowlevel-blt-bench in the following:
> > > - does not test different sized operations fitting to specific caches,
> > > destination is always 1920x1080
> > > - allows defining the affine transformation parameters
> > > - carefully computes operation extents to hit the COVER_CLIP fast paths
> > I've reviewed your version, looks fine to me. A very minor point: I'm not
> > sure it's worth making a copy of the transform struct at the start of
> > bench() because we mostly only use a pointer to the struct thereafter, so
> > you might as well have kept using bi->transform.
>
> Thank you, I'll take that as R-b.
Pushed.
58e21d3..e0c0153 master -> master
Thanks,
pq
More information about the Pixman
mailing list