[Pixman] [PATCH 2/4] build: Avoid phony `pixman` target in test/Makefile.win32

[Oded Gabbay]

On Wed, Dec 23, 2015 at 1:24 PM, Andrea Canciani <ranma42 at gmail.com> wrote:
> Instead of explicitly depending on "pixman" for the "all" and "check"
> targets, rely on the dependency to the .lib file
>
> Signed-off-by: Andrea Canciani <ranma42 at gmail.com>
> ---
>  test/Makefile.win32 | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/test/Makefile.win32 b/test/Makefile.win32
> index 6cfb4a7..bdd9b7f 100644
> --- a/test/Makefile.win32
> +++ b/test/Makefile.win32
> @@ -16,9 +16,9 @@ OBJECTS = $(patsubst %.c, $(CFG_VAR)/%.obj, $(SOURCES))
>  TESTS   = $(patsubst %,   $(CFG_VAR)/%.exe, $(TESTPROGRAMS))
>  OTHERS  = $(patsubst %,   $(CFG_VAR)/%.exe, $(OTHERPROGRAMS))
>
> -all: pixman inform $(TESTS) $(OTHERS)
> +all: inform $(TESTS) $(OTHERS)
>
> -check: pixman inform $(TESTS)
> +check: inform $(TESTS)
>         @failures=0 ; \
>         total=0 ; \
>         for test in $(TESTS) ; \
> @@ -46,9 +46,7 @@ $(CFG_VAR)/libutils.lib: $(libutils_OBJECTS)
>  $(CFG_VAR)/%.exe: $(CFG_VAR)/%.obj $(TEST_LDADD)
>         @$(LD) $(PIXMAN_LDFLAGS) -OUT:$@ $^
>
> -$(top_builddir)/pixman/$(CFG_VAR)/$(LIBRARY).lib: pixman
> -
> -pixman:
> +$(top_builddir)/pixman/$(CFG_VAR)/$(LIBRARY).lib:
>         @$(MAKE) -C $(top_builddir)/pixman -f Makefile.win32
>
> -.PHONY: all check pixman
> +.PHONY: all check
> --
> 2.5.4 (Apple Git-61)
>
> _______________________________________________
> Pixman mailing list
> Pixman at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/pixman

This patch is

Reviewed-by: Oded Gabbay <oded.gabbay at gmail.com>